Fix nearly all the compiler warnings in production code and tests #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still two warnings left in modules/http/src/test/scala/higherkindness/mu/rpc/http/GreeterServices.scala. But in trying to fix those I uncovered a mysterious `@http` annotation, which is a rabbit hole I don't really want to go down right now.
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
- Coverage 71.96% 71.75% -0.21%
==========================================
Files 68 69 +1
Lines 1045 1048 +3
Branches 12 13 +1
==========================================
Hits 752 752
- Misses 293 296 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still two warnings left in this file. But in trying to fix those I uncovered a mysterious
@httpannotation, which is a rabbit hole I don't really want to go down right now.What this does?
Changes, features, fixes ...
Checklist