Automatically register muSrcGen as a sourceGenerator #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't really make sense *not* to add the task to the list of sourceGenerators, as the list of generated source files would not be added to `managedSources`. That means even if you ran `muSrcGen` manually and then ran `compile`, the generated source files would not be compiled. Updated the plugin to automatically register the `muSrcGen` task as a sourceGenerator, and updated the misleading guidance in the documentation.
BenFradet
reviewed
Mar 2, 2020
There was a problem hiding this comment.
LGTM, though it seems the generated files don't compile: https://travis-ci.org/higherkindness/mu-scala/jobs/657341311#L936
|
@BenFradet Yes, the tests have started failing now that they are actually testing something 😄 I'll fix them. |
juanpedromoreno
approved these changes
Mar 2, 2020
A lot of them were not really testing anything. They were running `compile`, but that task wasn't compiling any files so it was trivially succeeding. Others just needed some tidy-up because they hadn't been touched for a long time.
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 71.75% 71.75%
=======================================
Files 69 69
Lines 1048 1048
Branches 13 13
=======================================
Hits 752 752
Misses 296 296Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on the documentation at the moment, and noticed this while I was going through a tutorial.
It doesn't really make sense not to add the task to the list of sourceGenerators, as the list of generated source files would not be added to
managedSources. That means even if you ranmuSrcGenmanually and then rancompile, the generated source files would not be compiled.Updated the plugin to automatically register the
muSrcGentask as a sourceGenerator, and updated the misleading guidance in the documentation.What this does?
Changes, features, fixes ...
Checklist