muSrcGenIdlType Tweak #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
commented
Mar 11, 2020
| @@ -10,6 +10,6 @@ permalink: guides | |||
| These guides are aimed at developers who are already familiar with Mu-Scala. | |||
|
|
|||
| If you are new to Mu-Scala, we recommend you read the [Getting Started | |||
| guide](../getting-started) and the [tutorials](../tutorials). | |||
| guide](getting-started) and the [tutorials](tutorials). | |||
There was a problem hiding this comment.
As the user is in the index.html, the path is omitted by the browser. It seems that it's not needed to go back with .. .
|
|
||
| If you are already familiar with Mu-Scala, you may want to read about how to use | ||
| its more advanced features in the [How-To Guides](../guides). | ||
| its more advanced features in the [How-To Guides](guides). |
There was a problem hiding this comment.
Same happens in this file (index.md).
peterneyens
approved these changes
Mar 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 71.63% 71.63%
=======================================
Files 69 69
Lines 1033 1033
Branches 19 21 +2
=======================================
Hits 740 740
Misses 293 293Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
Currently, the
sbt-mu-srcgenrequires the sbt settingmuSrcGenIdlTypewith a value different from the default one:Unknown. This happens even for those sbt projects or submodules that have no protocols to generate sources from.As a workaround, the user can set up any of the valid values but it's not quite user-friendly.
In this PR, I'm removing the existing validation and changing it by simple check if-else. If the module has a "valid"
muSrcGenIdlType, the plugin will run the code generator, and, in any other case, the plugin will return an empty list and, an informative message for the user.Additionally, I'm fixing a couple of broken links in the docs.
Checklist