Fix a few warnings #843
Fix a few warnings #843
Conversation
| @@ -25,6 +25,9 @@ import org.lyranthe.fs2_grpc.java_runtime.server.Fs2ServerCallHandler | |||
|
|
|||
| object fs2Calls { | |||
|
|
|||
| // TODO Support compression. It wasn't supported in fs2-grpc | |||
| // at the time this code was added (#477), but it is now. | |||
There was a problem hiding this comment.
I'll tackle this in a separate PR
| * reference it, so `_` gets turned into a fresh name e.g. `x$2`. The | ||
| * same thing happens even if you're not in a macro.) | ||
| * | ||
| * I'd say this is a bug in Scala. We work around it by manually adding |
There was a problem hiding this comment.
I'm going to see if I can fix this easily in scala/scala.
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
=========================================
+ Coverage 71.63% 71.84% +0.2%
=========================================
Files 69 68 -1
Lines 1033 1030 -3
Branches 21 14 -7
=========================================
Hits 740 740
+ Misses 293 290 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
👍 , it might be worth it to reestablish
mu-scala/project/ProjectPlugin.scala
Line 361 in e7d785d
| args <- findAnnotation(d.mods, "http").collect({ case Apply(_, args) => args }).toList | ||
| d <- rpcDefs.collect { case x if findAnnotation(x.mods, "http").isDefined => x } | ||
| // TODO not sure what the following line is doing, as the result is not used. Is it needed? | ||
| _ <- findAnnotation(d.mods, "http").collect({ case Apply(_, args) => args }).toList |
There was a problem hiding this comment.
might be worth it to log an issue about it so we don't forget about it as easily, wdyt?
|
@BenFradet For Scala 2.12, this PR gets us close to zero warnings, but not quite all the way there. We can't turn on For Scala 2.13 there are lots of warnings about deprecation of |
Fix most of the compiler warnings.
Fix #827