Remove F.never from Resource initializer #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it had `never` in the initializer, the initialization step would never finish. Also rewrite the `server` function to use `serverResource`, and add some comments.
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 57 57
Lines 824 824
Branches 5 5
=======================================
Hits 711 711
Misses 113 113
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it had
neverin the initializer, the initialization step would never finish.Also rewrite the
serverfunction to useserverResource, and add some comments.What this does?
Changes, features, fixes ...
Checklist