Make the OkHttp and Netty tests actually use OkHttp/Netty #928
Conversation
grpc-java chooses the client implementation by finding all `Provider`s on the classpath and picking the one with the highest priority. The `tests` module has both `grpc-netty` and `grpc-okhttp` on the classpath, so it will always choose the Netty implementation unless we specify otherwise. Added a couple of parameters to `ManagedChannelInterpreter`'s constructor to allow us to inject the appropriate implementation in tests, and updated the tests accordingly.
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 88.70% 88.71% +0.01%
==========================================
Files 58 58
Lines 832 833 +1
Branches 3 2 -1
==========================================
+ Hits 738 739 +1
Misses 94 94
Continue to review full report at Codecov.
|
| configList: List[ManagedChannelConfig] | ||
| configList: List[ManagedChannelConfig], | ||
| builderForAddress: (String, Int) => ManagedChannelBuilder[_] = ManagedChannelBuilder.forAddress, | ||
| builderForTarget: String => ManagedChannelBuilder[_] = ManagedChannelBuilder.forTarget |
There was a problem hiding this comment.
Would be this a breaking change?
There was a problem hiding this comment.
It is source-compatible because of the default arguments, but it is binary-incompatible: https://github.com/jatcwang/binary-compatibility-guide#dont-adding-parameters-with-default-values-to-methods
I'll leave the primary constructor alone and add a secondary constructor for use in tests.
| )(implicit F: Sync[F]) { | ||
|
|
||
| // Secondary constructor added for bincompat | ||
| def this( |
There was a problem hiding this comment.
Checked locally using MiMa that this fixes the bincompat breakage
grpc-java chooses the client implementation by finding all
Providerson the classpath and picking the one with the highest priority. The
testsmodule has bothgrpc-nettyandgrpc-okhttpon the classpath,so it will always choose the Netty implementation unless we specify
otherwise.
Added a couple of parameters to
ManagedChannelInterpreter'sconstructor to allow us to inject the appropriate implementation in
tests, and updated the tests accordingly.
What this does?
Changes, features, fixes ...
Checklist