Make Mu a normal compile-time dependency #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just tried publishing the plugin locally and using it in a project, and the `muSrcGen` task threw a ClassNotFoundException. Mu will be on the classpath of an end-user's Mu application, but it won't be on the classpath of the sbt plugin. So I don't think a "provided" dependency makes sense here. Confirmed locally that making it a normal dependency fixes the issue.
juanpedromoreno
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tried publishing the plugin locally and using it in a project, and the
muSrcGentask threw a ClassNotFoundException.Mu will be on the classpath of an end-user's Mu application, but it won't be on the classpath of the sbt plugin. So I don't think a "provided" dependency makes sense here.
Confirmed locally that making it a normal dependency fixes the issue.
At first I was worried we might have a circular dependency between Mu and the plugin, but that's not true. We just need to release Mu first, bump the Mu dependency version in the plugin, then release the plugin.