Add exception handling to Avro schema that have non-record response types #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 28, 2020 14:28
… gonna just push this and try to make it work in the commentary
2 tasks
dmarticus
commented
Jul 28, 2020
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Outdated
Show resolved
Hide resolved
added 6 commits
July 29, 2020 15:38
…en't records, but it won't fail the plugin
… parse rather than collecting everything but it's the least complicated implementation. I spent a long time reading up on SBT internals today and am doing my best to understand the correct approach but I also don't want to drag on for too long
dmarticus
commented
Jul 30, 2020
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Outdated
Show resolved
Hide resolved
added 3 commits
August 4, 2020 16:11
cb372
reviewed
Aug 6, 2020
core/src/main/scala/higherkindness/mu/rpc/srcgen/Generator.scala
Outdated
Show resolved
Hide resolved
…/sbt-mu-srcgen into dmarticus/marlow-issue513
…eed more help lol
…/sbt-mu-srcgen into dmarticus/marlow-issue513
cb372
reviewed
Aug 11, 2020
core/src/main/scala/higherkindness/mu/rpc/srcgen/GeneratorApplication.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/GeneratorApplication.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/GeneratorApplication.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/avro/AvroSrcGenerator.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/higherkindness/mu/rpc/srcgen/proto/ProtoSrcGenerator.scala
Outdated
Show resolved
Hide resolved
…ication.scala Co-authored-by: Chris Birchall <chris.birchall@47deg.com>
…enerator.scala Co-authored-by: Chris Birchall <chris.birchall@47deg.com>
…/sbt-mu-srcgen into dmarticus/marlow-issue513
core/src/main/scala/higherkindness/mu/rpc/srcgen/GeneratorApplication.scala
Outdated
Show resolved
Hide resolved
cb372
reviewed
Aug 12, 2020
core/src/main/scala/higherkindness/mu/rpc/srcgen/GeneratorApplication.scala
Outdated
Show resolved
Hide resolved
…ication.scala Co-authored-by: Chris Birchall <chris.birchall@47deg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, along with higherkindness/mu-scala#974, closes 47deg/marlow#513. This change adds error handling around trying to parse avro schema that use primitive types as methods instead of record types. This change is now ready for review!