[HIG-2525] ensure highlight-mask blocks image src (#85)

`highlight-mask` class should be evaluated during image snapshotting to drop the image src.
highlight · Aug 3, 2022 · 3276d91 · 3276d91
1 parent 8e06f47
commit 3276d91
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/packages/rrdom-nodejs/package.json b/packages/rrdom-nodejs/package.json
@@ -47,7 +47,7 @@
   },
   "dependencies": {
     "@highlight-run/rrdom": "0.1.17",
-    "@highlight-run/rrweb-snapshot": "1.1.25",
+    "@highlight-run/rrweb-snapshot": "1.1.26",
     "cssom": "^0.5.0",
     "cssstyle": "^2.3.0",
     "nwsapi": "^2.2.0"

diff --git a/packages/rrdom/package.json b/packages/rrdom/package.json
@@ -46,7 +46,7 @@
     "typescript": "^4.7.3"
   },
   "dependencies": {
-    "@highlight-run/rrweb-snapshot": "1.1.25"
+    "@highlight-run/rrweb-snapshot": "1.1.26"
   },
   "gitHead": "d5751f9e6c52a7734597c8595caa763d0f4dd4ad"
 }
diff --git a/packages/rrweb-snapshot/package.json b/packages/rrweb-snapshot/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@highlight-run/rrweb-snapshot",
-  "version": "1.1.25",
+  "version": "1.1.26",
   "description": "rrweb's component to take a snapshot of DOM, aka DOM serializer",
   "scripts": {
     "prepare": "npm run prepack",

diff --git a/packages/rrweb-snapshot/src/snapshot.ts b/packages/rrweb-snapshot/src/snapshot.ts
@@ -508,6 +508,7 @@ function serializeNode(
         inlineStylesheet,
         maskInputOptions,
         maskInputFn,
+        maskTextClass,
         dataURLOptions,
         inlineImages,
         recordCanvas,
@@ -647,6 +648,7 @@ function serializeElementNode(
     inlineStylesheet: boolean;
     maskInputOptions: MaskInputOptions;
     maskInputFn: MaskInputFn | undefined;
+    maskTextClass: string | RegExp;
     dataURLOptions?: DataURLOptions;
     inlineImages: boolean;
     recordCanvas: boolean;
@@ -666,6 +668,7 @@ function serializeElementNode(
     inlineStylesheet,
     maskInputOptions = {},
     maskInputFn,
+    maskTextClass,
     dataURLOptions = {},
     inlineImages,
     recordCanvas,
@@ -674,7 +677,9 @@ function serializeElementNode(
     enableStrictPrivacy,
     rootId,
   } = options;
-  let needBlock = _isBlockedElement(n, blockClass, blockSelector);
+  let needBlock =
+    _isBlockedElement(n, blockClass, blockSelector) ||
+    _isBlockedElement(n, maskTextClass, blockSelector);
   const tagName = getValidTagName(n);
   let attributes: attributes = {};
   const len = n.attributes.length;

diff --git a/packages/rrweb/package.json b/packages/rrweb/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@highlight-run/rrweb",
-  "version": "2.1.2",
+  "version": "2.1.3",
   "description": "record and replay the web",
   "scripts": {
     "prepare": "npm run prepack",
@@ -76,7 +76,7 @@
   },
   "dependencies": {
     "@highlight-run/rrdom": "0.1.17",
-    "@highlight-run/rrweb-snapshot": "1.1.25",
+    "@highlight-run/rrweb-snapshot": "1.1.26",
     "@types/css-font-loading-module": "0.0.7",
     "@xstate/fsm": "^1.4.0",
     "base64-arraybuffer": "^1.0.1",