-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delay canvas snapshotting per canvas #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayberryzane
approved these changes
Jul 21, 2023
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Jul 21, 2023
## Summary Changes the logic in rrweb (via highlight/rrweb#107) to delay snapshotting per canvas from the time a canvas is first seen. ## How did you test this change? https://app.highlight.io/1/sessions/w3B3ALspR2rzylo7hRQlsD1ptpu0?page=1&query=and%7C%7Ccustom_processed%2Cis%2Ctrue%7C%7Ccustom_created_at%2Cbetween_date%2C2023-06-21T22%3A26%3A01.274Z_2023-07-21T22%3A26%3A01.274Z&ts=280.741 ## Are there any deployment considerations? New firstload/client released.
Vadman97
added a commit
that referenced
this pull request
Jan 30, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Mar 4, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Mar 5, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Mar 5, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Apr 16, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Apr 17, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Jun 25, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Aug 5, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Aug 5, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Aug 26, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Sep 3, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Sep 9, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Sep 18, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Oct 9, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Oct 9, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Oct 15, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Oct 29, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Vadman97
added a commit
that referenced
this pull request
Oct 29, 2024
changes the `initialSnapshotDelay` to be applied per canvas from the time the canvas is first seen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the
initialSnapshotDelay
to be applied per canvas from the time the canvas is first seen.