support manual canvas snapshotting #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
et
approved these changes
Jul 27, 2023
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Jul 28, 2023
## Summary WebGL canvas elements can be double buffered, meaning that the canvas bitmap is not in javascript memory when we try to call `createImageBitmap`. If we hook into the webgl render loop of a given library to do the snapshotting, we have access to the canvas as it is still in memory. Adds a new manual snapshotting mode that exposes this functionality. Adds new rrweb logic in highlight/rrweb#108 ## How did you test this change? Babylon.js canvas snapshotting correctly in manual mode. <img width="1234" alt="Screenshot 2023-07-27 at 2 33 46 PM" src="https://github.com/highlight/highlight/assets/1351531/5e06a582-ebf1-45e3-af9b-2360e028cb58"> New docs on [vercel preview](https://highlight-landing-ld05dz2bn-highlight-run.vercel.app/docs/getting-started/client-sdk/replay-configuration/canvas). ## Are there any deployment considerations? New highlight.run minor version.
Vadman97
added a commit
that referenced
this pull request
Jan 30, 2024
Vadman97
added a commit
that referenced
this pull request
Mar 4, 2024
Vadman97
added a commit
that referenced
this pull request
Mar 5, 2024
Vadman97
added a commit
that referenced
this pull request
Mar 5, 2024
Vadman97
added a commit
that referenced
this pull request
Apr 16, 2024
Vadman97
added a commit
that referenced
this pull request
Apr 17, 2024
Vadman97
added a commit
that referenced
this pull request
Apr 23, 2024
Vadman97
added a commit
that referenced
this pull request
Jun 25, 2024
Vadman97
added a commit
that referenced
this pull request
Jun 25, 2024
Vadman97
added a commit
that referenced
this pull request
Jun 25, 2024
Vadman97
added a commit
that referenced
this pull request
Aug 5, 2024
Vadman97
added a commit
that referenced
this pull request
Aug 5, 2024
Vadman97
added a commit
that referenced
this pull request
Aug 26, 2024
Vadman97
added a commit
that referenced
this pull request
Sep 3, 2024
Vadman97
added a commit
that referenced
this pull request
Sep 9, 2024
Vadman97
added a commit
that referenced
this pull request
Sep 18, 2024
Vadman97
added a commit
that referenced
this pull request
Oct 9, 2024
Vadman97
added a commit
that referenced
this pull request
Oct 9, 2024
Vadman97
added a commit
that referenced
this pull request
Oct 15, 2024
Vadman97
added a commit
that referenced
this pull request
Oct 29, 2024
Vadman97
added a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See highlight/highlight#6139