update repo #115
Merged
update repo #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vadman97
force-pushed
the
vadim/rrweb-update-repo
branch
5 times, most recently
from
1bd08cb to
c6e4b94
Compare
Vadman97
force-pushed
the
vadim/rrweb-update-repo
branch
2 times, most recently
from
0d5cd39 to
7384bca
Compare
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Mar 12, 2024
## Summary highlight/rrweb#115 hoping this will fix some [scroll issues](highlight/rrweb@e607e83) reported by users recently, as well as some canvas recording issues fixed in rrweb renames our rrweb forks back to the original names to make it easier to rebase in the future. we will still be using our local fork via the `"rrweb": "workspace:*"` dependencies in the `package.json`s ## How did you test this change? in progress testing via reflame and local deploy    ## Are there any deployment considerations? changeset ## Does this work require review from our design team? no
Vadman97
force-pushed
the
vadim/rrweb-update-repo
branch
from
7384bca to
9817409
Compare
Vadman97
force-pushed
the
vadim/rrweb-update-repo
branch
from
9817409 to
7535ca1
Compare
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Apr 17, 2024
## Summary Fix `.tagName` null access issue reported on [discord](https://discord.com/channels/1026884757667188757/1229747689353252875) via rrweb-io/rrweb#1445 highlight/rrweb#115 Closes HIG-4504 ## How did you test this change? reflame ## Are there any deployment considerations? changeset ## Does this work require review from our design team? no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.