Added support for inactive threshold #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This still has the snapshot/ directory in the repo. |
jay-khatri
requested changes
Feb 16, 2021
There was a problem hiding this comment.
Looks good. Right now you're doing a ~3n pass over the interaction events; I think you could technically do all of this in one pass.
In other words, while building the intervals, keep track of the state of the previous interval [active/inactive]. Based on the state of the current interval, append/don't-append. You can also probably selectively choose to keep inactive intervals based on that threshold in the same pass.
But this is fine lol, doesn't really matter. A few small naming things.
…anthony/hig-122-add-feature-to-modify-threshold-for
jay-khatri
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.