Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow "make" as alias for "makefile" #2883

Closed
tripleee opened this issue Nov 20, 2020 · 6 comments · Fixed by #2891
Closed

Please allow "make" as alias for "makefile" #2883

tripleee opened this issue Nov 20, 2020 · 6 comments · Fixed by #2891
Labels
Milestone

Comments

@tripleee
Copy link
Contributor

Could you please allow ```make as a convenient shorthand for ```makefile? This is definitely more guessable than the currently supported aliases ```mk and ```mak, and the name of the actual command you use to run a Makefile.

@joshgoebel
Copy link
Member

Hmmmm... are there any other makes our there other than GNU make that would make "make" ambiguous?

@tripleee
Copy link
Contributor Author

The original make from 1976 is the lowest common denominator here; GNU make significantly extends the syntax in ways which are incompatible with e.g. BSD make and nmake but that is really beside the point here. All of these use make as the command name (at least as an option; I suppose nmake is most commonly invoked with that name) and Makefile as the standard input file name, with random .mk and probably occasionally .mak files as a common convention for nonstandard input files. For more background, see https://en.wikipedia.org/wiki/Make_(software)

@joshgoebel
Copy link
Member

@allejo Any thoughts? I don't think I'm opposed to this. We'd need:

  • Update SUPPORTED_LANGUAGES
  • Update makefile.js

@joshgoebel
Copy link
Member

@tripleee Are you wanting to pull together a small PR for this if we green light?

@tripleee
Copy link
Contributor Author

I can try to step in if there's nobody around who is familiar with Javacript in general and this project in particular.

@joshgoebel
Copy link
Member

No one is around if everyone asks that first. ;-) "Be the change you want to see in the world." - Gandhi

Plus I always try to encourage new contributors - doubly so for easy things. If you cut your teeth on just adding an alias then perhaps when you see how deficient the Makefile grammar is you'll be more tempted to come back and make a contribution to improve it. :-) That's just a hope of course. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants