Discuss: Rename className to scope

[joshgoebel]

Is your request related to a specific problem you're having?

Yes, once we add nested scope then technically className is no longer accurate, plus it's length has always bothered me.

The solution you'd prefer / feature you'd like to see added...

I propose we rename it scope...

Before:

      {
        className: 'title.class',
        match: '^\\w+(?=:)'
      },

After:

      {
        scope: 'title.class',
        match: '^\\w+(?=:)'
      },

Of course we'd continue to support className (deprecated)... this would be an alias essentially.

Any alternative solutions you considered...

Nope. TextMate grammars calls this captures/name in the grammar and "scopes" is the concept I believe.

 {  match = '(@selector\()(.*?)(\))';
    captures = {
       1 = { name = 'storage.type.objc'; };
       3 = { name = 'storage.type.objc'; };
    };
 };

Additional context...

None.

[joshgoebel]

CC @highlightjs/core

[allejo]

No objections here, makes sense to me

[NullVoxPopuli]

Would this still support multiple classes? I've been adding multiple classes for debugging. Otherwise I'm 👍

[joshgoebel]

Same behavior, just a name change since technically "function.title.call" is NOT a class name. And I've never loved the verbosity of className...