(PHP) Attributes with \ highlighted as comment instead of meta

[DanielBadura]

Describe the issue
Using Attributes with \ are hilighted as comments instead of meta. If it's only a leading \ it is working as expected. But as soons as we add a \ after that, the highlighting is not correct anymore. This is a common situation when using attributes with PHP for example using Doctrine or Swagger etc.

Which language seems to have the issue?
php

Are you using highlight or highlightAuto?

highlight

Sample Code to Reproduce

use Doctrine\ORM\Mapping as ORM;

#[\ORM\Entity]
final class Account
{
    #[ORM\Id]
    #[ORM\Column('uuid')]
    private AccountId $id;

    #[Column('string')]
    #[\Column('string')]
    private string $name;
}

Expected behavior
Same meta highlighting in these cases.

Additional context
Using highlight js through https://github.com/rehypejs/rehype-highlight which is using https://github.com/wooorm/lowlight. But i dont think the problem comes from there, since it's also wrong highlighted in the demo.

[joshgoebel]

What is the definition of an attribute in PHP, just #[...] or are there very precise rules?

[DanielBadura]

Yes, Attributes are beginning with #[ and ending with ]. They can applied on various things in the language:

• functions (including closures and short closures)
• classes (including anonymous classes), interfaces, traits
• class constants
• class properties
• class methods
• function/method parameters

Also, each attribute may have values associated with it, but doesn't have to, similar to how a constructor of a class works. Also Attributes can be nested.

class Value 
{
}

#[Attribute('value', new Value(), new Attribute()]
function foo() {}

Here an example how PHPStorm is highlighting it:

[joshgoebel]

Could you test #4119?

[DanielBadura]

Yeah, this worked. So it was just the all uppercase.. :D

I just realised that i found another case which is not correctly working:

#[Event('car_ride.booked')]
final class RideBooked
{
    public function __construct(
        #[AccountNormalizer]
        public readonly Account $account
    ){}
}

Here, the attribute over a method argument of a function definition is not highlighted.

[joshgoebel]

Try that fix.

[DanielBadura]

Yes this works, thank you! Very much appreciate it!