Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php) improves attribute highlighting #4119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(php) improves attribute highlighting #4119

wants to merge 2 commits into from

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Sep 22, 2024 •
edited
Loading

Fixes #4115.

Changes

  • Support uppercase names inside PHP attribute blocks

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

2 files changed

Total change +36 B

View Changes
file base pr diff
es/languages/php.min.js 2.62 KB 2.64 KB +18 B
languages/php.min.js 2.63 KB 2.64 KB +18 B

@joshgoebel joshgoebel mentioned this pull request Sep 22, 2024
Open
@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +55 B

View Changes
file base pr diff
es/core.min.js 8.18 KB 8.18 KB -3 B
es/highlight.min.js 8.18 KB 8.18 KB -3 B
es/languages/php.min.js 2.62 KB 2.65 KB +31 B
highlight.min.js 8.22 KB 8.22 KB -1 B
languages/php.min.js 2.63 KB 2.66 KB +31 B

@joshgoebel
Copy link
Member Author

Just needs a changes entry and rebase.

@wkania
Copy link
Contributor

wkania commented Oct 6, 2024

And maybe change one of the attributes to uppercase inside of test. #[ASSERT(value: 1234)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(PHP) Attributes with \ highlighted as comment instead of meta
3 participants
@joshgoebel @wkania @DanielBadura