-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(python) Match numeric literals per the language reference #2780
enh(python) Match numeric literals per the language reference #2780
Conversation
Great start! Looking good. |
@joshgoebel I see that a WIP 10.4.0 has been added to CHANGES.md... should this PR be part of that version, or a new WIP 10.3.2? |
10.4, x.x.Y is only for patch releases. Are you wanting to solve the issue here on top of this work or make another PR after this one is merged? |
Looking good other than the notes I added. Almost there. |
68c500d
to
2c59cf0
Compare
I'd prefer to handle the Ruby updates in a separate PR, which I can start on shortly (it will look very similar to this one). |
Oh sure, I thought there was more python stuffs. :) |
@gibson042 Thanks so much! |
@gibson042 Can you please have a look at #2985 Is there a reason you went with \b for terminators for many numbers? IE, a specific problem you were trying to solve? |
Ping @gibson042 |
@gibson042 Ping. |
1 similar comment
@gibson042 Ping. |
Whoops, I'm not sure how I missed all those (but it has been a heck of a year). The primary reason for leading |
Thanks - we're looking for an easy/simple fix though. I don't want to just keep adding tons of edge cases/complexity only to deal with code golf. I'd rather just say we don't support it. So if nothing is obviously don't throw a bunch of time into coming up with anything crazy. |
I started to work on #2766, but realized that the Python foundation I planned to use was itself incomplete, so I'm testing the waters with this and can follow up if it is accepted.
Changes
Replaced generic numeric regular expressions with specific ones to match the Python language reference.
Checklist
CHANGES.md
AUTHORS.txt
, under Contributors