fix(properties) fix incorrect handling of non-alphanumeric keys #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties is leaving :common in v11 and honestly there are no narrow rules here to give us real relevance. Since we are now widening the key rule even further this problem would become even worse. Therefore, we will disable auto-detect.
joshgoebel
approved these changes
Apr 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3064
Changes
Removed the special case for non-alphanumeric characters keys, as there are no restrictions for the set of character, and no character has a special meaning (excluding separators of course).
Checklist
Added markup tests, or theydon't apply here because there is nothing new in markupCHANGES.md