Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(nsis) Update language string pattern #3420

Merged
merged 4 commits into from
Dec 6, 2021
+2 −1
Merged

enh(nsis) Update language string pattern #3420

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee39dfd
enh(nsis) Update language strings pattern
idleberg Dec 4, 2021
434d925
(chore) Update CHANGES.md
idleberg Dec 4, 2021
b41b46f
rearrange regex, avoid escape that's not required
joshgoebel Dec 6, 2021
732d090
Merge branch 'main' into patch-4
joshgoebel Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@ Grammars:
- fix(fsharp) Highlight operators, match type names only in type annotations, support quoted identifiers, and other smaller fixes. [Melvyn Laïly][]
- enh(java) add `sealed` and `non-sealed` keywords (#3386) [Bradley Mackey][]
- enh(nsis) Update defines pattern to allow `!` (#3417) [idleberg][]
- enh(nsis) Update language strings pattern to allow `!` (#3420) [idleberg][]
- fix(clojure) Several issues with Clojure highlighting (#3397) [Björn Ebbinghaus][]
- fix(clojure) `comment` macro catches more than it should (#3395)
- fix(clojure) `$` in symbol breaks highlighting
2 changes: 1 addition & 1 deletion src/languages/nsis.js
View file
Original file line number Diff line number Diff line change
@@ -167,7 +167,7 @@ export default function(hljs) {
const LANGUAGES = {
// $(language_strings)
className: 'variable',
begin: /\$+\([\w^.:-]+\)/
begin: /\$+\([\w^.:!-]+\)/
};

const PARAMETERS = {