Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Rose Pine themes #4046

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

wilkinson4
Copy link
Contributor

@wilkinson4 wilkinson4 commented Apr 29, 2024

Rose Pine

rosePine

Rose Pine Moon

rosePineMoon

Rose Pine Dawn

rosePineDawn

@joshgoebel
Copy link
Member

Please provide a few snaps to show us what it looks like.

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 Added Files

View Changes
file size
styles/rose-pine-dawn.min.css +490 B
styles/rose-pine-moon.min.css +486 B
styles/rose-pine.min.css +487 B

No changes

No existing files changed.

@wilkinson4
Copy link
Contributor Author

Please provide a few snaps to show us what it looks like.

Screenshots added. Thank you!

@wilkinson4
Copy link
Contributor Author

@joshgoebel Is this good to go, or something I can fix possibly?

@joshgoebel joshgoebel force-pushed the ww/add-rose-pine-theme branch from ec812bc to c14fd45 Compare July 6, 2024 21:20
Copy link

github-actions bot commented Jul 6, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 Added Files

View Changes
file size
styles/rose-pine-dawn.min.css +490 B
styles/rose-pine-moon.min.css +486 B
styles/rose-pine.min.css +487 B

3 files changed

Total change -7 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB -2 B
es/highlight.min.js 8.2 KB 8.2 KB -2 B
highlight.min.js 8.23 KB 8.23 KB -3 B

@joshgoebel
Copy link
Member

Please add an entry to the changelog.

@@ -20,7 +20,7 @@ Developer Tools:

Themes:

- Nothing yet.
- Added `Rosé Pine` theme [William Wilkinson][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a link as well line 30, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😂 , done.

@wilkinson4 wilkinson4 force-pushed the ww/add-rose-pine-theme branch from 8083747 to 7bbf0d3 Compare July 9, 2024 20:23
@wilkinson4 wilkinson4 force-pushed the ww/add-rose-pine-theme branch from 7bbf0d3 to a5006ef Compare July 9, 2024 20:25
@wilkinson4 wilkinson4 requested a review from joshgoebel July 9, 2024 20:26
Copy link

github-actions bot commented Jul 9, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 Added Files

View Changes
file size
styles/rose-pine-dawn.min.css +490 B
styles/rose-pine-moon.min.css +486 B
styles/rose-pine.min.css +487 B

3 files changed

Total change +9 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +3 B
es/highlight.min.js 8.2 KB 8.2 KB +3 B
highlight.min.js 8.23 KB 8.23 KB +3 B

@joshgoebel joshgoebel merged commit 78f3b1c into highlightjs:main Jul 9, 2024
19 checks passed
@wilkinson4 wilkinson4 deleted the ww/add-rose-pine-theme branch July 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants