fix(typescript) better highlighting of optionals #4114
Conversation
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +71 B View Changes
|
src/languages/lib/ecmascript.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| export const IDENT_RE = '[A-Za-z$_][0-9A-Za-z$_]*'; | |||
| export const IDENT_RE = '[A-Za-z$_][0-9A-Za-z$_]*\\??'; | |||
There was a problem hiding this comment.
Is ? truly a valid ECMAScript identifier, or just in TS?
There was a problem hiding this comment.
Youre right , ive managed to scope the new fix to just ts in the new commit
src/languages/typescript.js
Outdated
| const namespace = 'bar'; | ||
| */ | ||
|
|
||
| const OPTIONAL_PROPERTY_RE = IDENT_RE + '\\s*\\?'; |
There was a problem hiding this comment.
Please provide an example of what this is trying to do.
There was a problem hiding this comment.
in my new commit ive added some test so i found that it was failing on some new tcs so ill explain the new one
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +74 B View Changes
|
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +79 B View Changes
|
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +79 B View Changes
|
|
I rewrote this to use more of the existing |
joshgoebel
changed the title
its highlighting wrong i dont see what seems to be the issue in the previous commit i made can you ellaborate a little more |
The tests [you provided] (including the one you show above) are all still green... given that the tests are all green, my version has the exact same behavior as yours. So... not sure what you are seeing.
It's just a bit too complex... we usually try for the simplest solutions. |
ah my apologies i changed to a different style and thought comment were being highlighted wrong |
Fixed the optional property in ts not being highlighted
Resolves #3613
before:
after:
Checklist
CHANGES.md