-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the using
keyword per the "Explicit Resource Management" proposal
#4135
Merged
joshgoebel
merged 2 commits into
highlightjs:main
from
sufianrhazi:javascript-explicit-resource-management
Oct 24, 2024
Merged
Add the using
keyword per the "Explicit Resource Management" proposal
#4135
joshgoebel
merged 2 commits into
highlightjs:main
from
sufianrhazi:javascript-explicit-resource-management
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Oct 20, 2024
joshgoebel
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add the comment then this is good to merge!
Thank you! Just added the suggested changes. |
joshgoebel
approved these changes
Oct 24, 2024
This ECMAScript proposal adds a new keyword (`using`). It's reached stage 3, which is "recommended for implementation" Proposal: https://github.com/tc39/proposal-explicit-resource-management ECMAScript proposal process: https://tc39.es/process-document/
Co-authored-by: Josh Goebel <me@joshgoebel.com>
3adcade
to
f7e47ab
Compare
Build Size ReportChanges to minified artifacts in 11 files changedTotal change +23 B View Changes
|
1 similar comment
Build Size ReportChanges to minified artifacts in 11 files changedTotal change +23 B View Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This ECMAScript proposal adds a new keyword (
using
). It's reached stage 3, which is "recommended for implementation":The change itself is very small, I've just added the
using
keyword to the list of keywords insrc/languages/lib/ecmascript.js
. I've also updated an existing keyword test adding a case to ensureusing
is rendered as<span class="hljs-keyword">using</span>
in a declaration.I didn't update the
CHANGES.md
, since I'm not sure if I should cut a new version for this? But let me know what to do and I can do it.Checklist
CHANGES.md