fix(basic) - closing quotation marks not required for a PRINT statement #4137
Conversation
src/languages/basic.js
Outdated
| hljs.QUOTE_STRING_MODE, | ||
| { | ||
| // Match strings that start with " and end with " or a line break | ||
| className: 'string', |
There was a problem hiding this comment.
| className: 'string', | |
| scope: 'string', |
src/languages/basic.js
Outdated
| { | ||
| // Match strings that start with " and end with " or a line break | ||
| className: 'string', | ||
| begin: '"', |
There was a problem hiding this comment.
Please use regex literals for all the regex, rather than strings.
|
@joshgoebel the changes for regex literals are made, please review them once. |
src/languages/basic.js
Outdated
| scope: 'string', | ||
| begin: /"/, | ||
| end: /"|$/, | ||
| illegal: /\n/, |
There was a problem hiding this comment.
I'm not sure this illegal has any effect at all since the $ should match first (or does it match after)... are you seeing different behavior with/without illegal?
There was a problem hiding this comment.
I added the illegal keyword to ensure the string doesn't span multiple lines. But I can't see a different behavior without it. This can be removed to optimize the code.
There was a problem hiding this comment.
It can't span multiple lines because the $ will match the end of the first line.
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +61 B View Changes
|
Fixed the closing quotations marks considered for string highlighting in basic.
Resolves #3996
Changes
Before
After
Checklist
CHANGES.md