Fix #3928: support digit separators (') in C++ integer literals in #define #4322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erals in #define
Yang062
approved these changes
Oct 9, 2025
|
Thanks for the review, @Yang062! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3928 by adding support for single-quote (') digit separators in C++ integer literals inside #define macros and normal code. Previously, such literals were not highlighted correctly in highlight.js.
Changes made:
Existing preprocessor tests may highlight numbers differently due to the fix; this is expected.Also the behavior for digit separators in integer literals is changed; all other syntax highlighting remains unchanged.
Closes#3928