Improve support for JSX #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coming from the description in #766, I was about to ask you to also add optional whitespace after |
|
Oh and a very special thank you for adding tests, too! |
|
Thanks for merging! Any guesses when the next release of highlight.js will go out? |
|
We've got 10 open issues targeted for the next release and, judging by past empirical evidence, we might sort it out in two coming weeks. |
|
why can't we use the same rules babel-sublime is using? it's doing a pretty good job with JSX |
|
Could you please improve support of typescript with embedded jsx? (it called tsx) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
Also adds a few JavaScript markup tests -- one using React JSX syntax, one using the JavaScript example from the highlight.js home page.