Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style heading-like markers as 'section' #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 14, 2022

In the GitHub theme, this will make them bold and red, so they really stand out. As is appropriate for strings that fundamentally divide the various portions of the specfile contents.

@joshgoebel
Copy link
Member

I would just mention that not all themes are going to look good because section is most often reserved for Markdown styling (not code) and not all theme designers consider this type of mix. Just food for thought.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 14, 2022

@joshgoebel Hmmm. I suppose that's a possibility.

I'm apparently wrong about the GitHub theme, too — that's what Fedora is using, in theory, but it's a version that's at least 13 months out of date. In the current version, hljs-section is styled #005cc5 and bold, not red (#990000) and bold.

I'd be open to a code-based alternative, though. Semantically, "keyword" feels a bit lacking to me. I know older themes represent "class" as .hljs-class .hljs-title, whereas more current ones use .hljs-title.class_ instead; perhaps some variation on that? It's closer to the semantics of what those particular divisions represent, in the source.

@joshgoebel
Copy link
Member

It's tough, there are pros and cons... section could semantically be best, I dunno... but title.class (.hljs-title.class_) likely looks better with more themes since it's more of a common pairing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants