Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone sign must be positive for timezones like +05:00 #82

Closed
highsource opened this issue May 7, 2015 · 4 comments
Closed

Timezone sign must be positive for timezones like +05:00 #82

highsource opened this issue May 7, 2015 · 4 comments
Assignees
@highsource
Labels
bug
Milestone
2.3.0

Comments

@highsource
Copy link
Owner

No description provided.

@highsource highsource added the bug label May 7, 2015
@highsource highsource added this to the 2.3.0 milestone May 7, 2015
@highsource highsource self-assigned this May 7, 2015
@highsource
Copy link
Owner Author

Currently the timezone for +05:00 would be -300. Correct would have been 300.

Planned for 2.3.x as this is not backwards compatible.

highsource added a commit that referenced this issue May 7, 2015
@highsource
Issue #82. Test for the timezone.
291d575
highsource added a commit that referenced this issue May 7, 2015
@highsource
Issue #82. Fixed negative timezone problem.
a4ee0cd
highsource added a commit that referenced this issue May 7, 2015
@highsource
Issue #82.
5538890
highsource added a commit that referenced this issue May 7, 2015
@highsource
Issue #82. Fixed tests.
46de19f
highsource added a commit that referenced this issue May 7, 2015
@highsource
Issue #82. Updated the scripts.
2fec262
highsource added a commit that referenced this issue May 7, 2015
@highsource
Issue #82.
d704aae
@highsource
Copy link
Owner Author

This is correct now.

@ghost
Copy link

ghost commented Aug 18, 2015

Thanks for fixing this! Would this also explain why I am getting positive values (e.g. 420) for negative timezones (e.g. -07:00)?

@highsource
Copy link
Owner Author

If you mean pre-2.3.0 then yes, this was the problem. With 2.3.0 and up this should no longer be the case. If you keep getting different-signed values, please report an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@highsource highsource

Labels
bug
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@highsource