-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log to syslog #55
Log to syslog #55
Conversation
Moved all the logging from print_and_log to logging, but syslog doesn't work. Need to debug.
Thanks! Looks like I noticed two things:
|
I addressed all comments. Not sure how I ended up with a different log format to start with… |
Thanks for the quick turnaround. Looks like the syslog_socket variable is referenced outdented from the block it is defined in the loop now. Looks like we would want to adjust that reference, but beyond that, ready to merge your PR since we are in the middle of beta testing v2.0 and don't need this to be perfect |
Should be fixed. Thanks. |
Maybe I'm tired, but looks like this would be missing whitespace before 'via'? Sorry for all the revisions! |
Oopsie. Fixed. |
Thanks. The README is not up to date but I'll merge now! I can check out windows logging if I get the chance and document the system logging at that point perhaps? Thanks for your ongoing contributions! |
Unifies logging to use
logging
and adds option to log to syslog.Note that it works on Linux, and I cannot figure out why it doesn't on macOS (
/var/run/syslog
should be the socket to write to…).Implements #54 on Linux, maybe on macOS too.