Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was changed in this pull request?
Swap the way clodius populates coordinates for tiles, such that bin1 is rows and bin2 is cols.
Why is it necessary?
Bins 1 and 2 have been getting mapped to the horizontal (columns) and vertical (rows) axes in HiGlass, respectively, which is the opposite of the matrix convention (first axis vertical and second being horizontal). This had no impact at all on symmetric heatmaps but does affect new asymmetric ones. See higlass/higlass#704.
While we can introduce an option to transpose the axes on the front end, we should alter the default to be the least surprising choice given the orientation of HiGlass's axes (bin1 = matrix i = vertical from top-to-bottom; bin2 = matrix j = horizontal from left-to-right; origin in the top left corner).
This will probably also require swapping the direction tile "mirroring" works on the client.
Checklist