This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Pass in auth token #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkerpedjiev
commented
Aug 21, 2023
higlass_widget/widget.py
Outdated
| @@ -10,6 +10,8 @@ class HiGlassWidget(anywidget.AnyWidget): | |||
| _esm = pathlib.Path(__file__).parent / "widget.js" | |||
| _css = "https://esm.sh/higlass@1.12/dist/hglib.css" | |||
| _viewconf = t.Unicode("null").tag(sync=True) | |||
|
|
|||
| auth_token = t.Unicode().tag(sync=True) | |||
pkerpedjiev
force-pushed
the
pkerpedjiev/auth-token
branch
from
3a527f1
to
b873be3
Compare
pkerpedjiev
force-pushed
the
pkerpedjiev/auth-token
branch
from
b873be3
to
b8c4e3e
Compare
manzt
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Pardon the formatting. My IDE did it 😬.
Lol, no worries. We don't have any linting/formatting setup and 2 spaces over tabs is more standard in JS land.
What do we think about having an options dict (rather than a separate trait for each option):
HiGlassWidget(conf.dict(), options={"authToken": "XXXX", "theme": "dark" })Second, since migrating to anywidget, I think its probably way nicer to move this to higlass-python? Thoughts?
|
Fully support 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to pass in an auth_token via the
auth_tokenkwarg.Pardon the formatting. My IDE did it 😬. If it's super annoying I can submit another PR with just formatting changes. Or try to submit with the previous formatting and just the functional change.
I marked the only two lines of functional changes.