Fix ["revoked"] KeyError for deserialize_own_connection (#1720)

Signed-off-by: Nick <83879796+sdf9s8d76f@users.noreply.github.com>
Co-authored-by: FasterSpeeding <lucina@lmbyrne.dev>

changes/1720.bugfix.md

@@ -0,0 +1 @@
+Fix optional connection "revoked" field KeyError when fetching connections.

hikari/impl/entity_factory.py

@@ -572,7 +572,7 @@ def deserialize_own_connection(self, payload: data_binding.JSONObject) -> applic
             id=payload["id"],
             name=payload["name"],
             type=payload["type"],
-            is_revoked=payload["revoked"],
+            is_revoked=payload.get("revoked", False),
             integrations=integrations,
             is_verified=payload["verified"],
             is_friend_sync_enabled=payload["friend_sync"],

tests/hikari/impl/test_entity_factory.py

@@ -872,8 +872,11 @@ def test_deserialize_own_connection(self, entity_factory_impl, own_connection_pa
         assert own_connection.visibility == application_models.ConnectionVisibility.NONE
         assert isinstance(own_connection, application_models.OwnConnection)
 
-    def test_deserialize_own_connection_when_integrations_is_None(self, entity_factory_impl, own_connection_payload):
+    def test_deserialize_own_connection_with_nullable_and_optional_fields(
+        self, entity_factory_impl, own_connection_payload
+    ):
         del own_connection_payload["integrations"]
+        del own_connection_payload["revoked"]
         own_connection = entity_factory_impl.deserialize_own_connection(own_connection_payload)
         assert own_connection.id == "2513849648abc"
         assert own_connection.name == "FS"