-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of non-existent attachment attachment paths #826
Labels
enhancement
New feature or request
Comments
2 tasks
The
|
FasterSpeeding
added a commit
to FasterSpeeding/hikari
that referenced
this issue
Mar 2, 2022
FasterSpeeding
added a commit
to FasterSpeeding/hikari
that referenced
this issue
Mar 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Consider checking if file attachments exist before passing them through to aiohttp.
Problem
The current error for a file not being found is the following
This is unintuitive and directs away from the actual problem of the file not existing and if we had an explicit check before the file was handed over to aiohttp we could improve the user experience when dealing with this issue.
Ideal implementation
Check if file attachments exist before passing them through to aiohttp.
Checklist
If it is a follow up of another issue, I have specified it.
The text was updated successfully, but these errors were encountered: