Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orjson as an optional speedup and allow to pass custom json.dumps and json.loads functions to all components. #1486

Merged
merged 22 commits into from
Feb 5, 2023
Merged

Add orjson as an optional speedup and allow to pass custom json.dumps and json.loads functions to all components. #1486

merged 22 commits into from
Feb 5, 2023

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Jan 25, 2023

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

Closes #1453

@davfsa davfsa added the enhancement New feature or request label Jan 25, 2023
@davfsa davfsa requested a review from FasterSpeeding January 25, 2023 21:48
@davfsa davfsa requested review from FasterSpeeding and zunda-arrow and removed request for zunda-arrow January 27, 2023 19:24
zunda-arrow
zunda-arrow reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@zunda-arrow zunda-arrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I checked the performance of using isinstance to check if decoding/encoding is required and the performance loss is negligible compared to parsing a large data structure.

@davfsa
Update tests/hikari/impl/test_rest.py
5d9f306 
Signed-off-by: davfsa <davfsa@gmail.com>
@davfsa
Update tests/hikari/impl/test_rest.py
7e21c71 
Signed-off-by: davfsa <davfsa@gmail.com>
@davfsa
Apply suggestions from code review
1013925 
Signed-off-by: davfsa <davfsa@gmail.com>
@davfsa davfsa requested a review from FasterSpeeding February 1, 2023 19:45
@davfsa davfsa merged commit 0a08d1a into hikari-py:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zunda-arrow zunda-arrow zunda-arrow left review comments

@FasterSpeeding FasterSpeeding FasterSpeeding approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pottential speedup: ujson or orjson
3 participants
@davfsa @FasterSpeeding @zunda-arrow