New tests #249
Merged
New tests #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 29, 2020
ghost
reviewed
Sep 29, 2020
ghost
reviewed
Sep 29, 2020
ghost
reviewed
Sep 29, 2020
|
This kind of collides in one or two places with what i am doing, and what i am doing resolves one or two of these issues so I have re-targeted my branch for this PR if you don't mind :) feel free to continue adding stuff to said branch. You'll see what I've changed. |
ghost
changed the base branch from
master
to
task/deprecating-duplicated-stub-helpers
davfsa
force-pushed
the
task/more-testing
branch
from
c3ac15a
to
d21d533
Compare
|
Ping me when this isn't a draft and I'll merge it. |
ghost
force-pushed
the
task/deprecating-duplicated-stub-helpers
branch
from
a027e31
to
87c10f2
Compare
ghost
changed the base branch from
task/deprecating-duplicated-stub-helpers
to
master
davfsa
force-pushed
the
task/more-testing
branch
from
d21d533
to
2979078
Compare
davfsa
force-pushed
the
task/more-testing
branch
from
2979078
to
cbb7466
Compare
|
Idk how nor when I closed this, but was a mistake 😅 @nekokatt ready for review |
davfsa
force-pushed
the
task/more-testing
branch
from
64dd25e
to
e844661
Compare
ghost
reviewed
Oct 4, 2020
| assert rest_provider.cache == cache | ||
|
|
||
| def test_executor_property(self, rest_provider, executor): | ||
| assert rest_provider.executor == executor |
There was a problem hiding this comment.
probs should use is here. Doesn't matter really though.
ghost
approved these changes
Oct 4, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
noxand all the pipelines have passed.Related issues
#47