Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tests #50

Merged
1 commit merged into from
Aug 21, 2020
Merged

New tests #50

1 commit merged into from
Aug 21, 2020

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Aug 20, 2020

  • Rename some properties for consistency
  • Rename format_* args for consitency

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

#47

@davfsa davfsa added the enhancement New feature or request label Aug 20, 2020
@davfsa davfsa requested review from FasterSpeeding and a user August 20, 2020 14:46
@davfsa davfsa self-assigned this Aug 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   79.37%   79.83%   +0.45%     
==========================================
  Files          77       77              
  Lines        9630     9630              
  Branches     1233     1233              
==========================================
+ Hits         7644     7688      +44     
+ Misses       1931     1887      -44     
  Partials       55       55              
Impacted Files Coverage Δ
hikari/applications.py 100.00% <100.00%> (ø)
hikari/channels.py 100.00% <100.00%> (ø)
hikari/guilds.py 96.14% <100.00%> (+12.12%) ⬆️
hikari/invites.py 86.41% <100.00%> (ø)
hikari/users.py 100.00% <100.00%> (ø)
hikari/webhooks.py 67.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ebc81...5476e32. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should name format to something else to prevent builtin shadowing.

Maybe ext for file extension?

hikari/guilds.py Outdated Show resolved Hide resolved
@davfsa davfsa force-pushed the task/tests branch 2 times, most recently from 8046fef to ed153df Compare August 21, 2020 15:40
  - Rename `format_*` arg `format` to `ext`
@ghost ghost merged commit fa1d2c2 into hikari-py:master Aug 21, 2020
@davfsa davfsa deleted the task/tests branch August 22, 2020 17:18
@ghost ghost added this to the 2.0.0 milestone Sep 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants