Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tests #80

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Add new tests #80

merged 1 commit into from
Aug 23, 2020

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Aug 23, 2020

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

#47

@davfsa davfsa added the testing Improvements or additions to tests label Aug 23, 2020
@davfsa davfsa requested review from FasterSpeeding and a user August 23, 2020 11:42
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #80 into master will increase coverage by 0.55%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   79.77%   80.33%   +0.55%     
==========================================
  Files          78       78              
  Lines        9711     9712       +1     
  Branches     1238     1238              
==========================================
+ Hits         7747     7802      +55     
+ Misses       1908     1854      -54     
  Partials       56       56              
Impacted Files Coverage Δ
hikari/api/event_dispatcher.py 100.00% <ø> (ø)
hikari/impl/event_manager_base.py 65.00% <85.71%> (+39.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7980d...d66ea0e. Read the comment docs.

Copy link
Collaborator

@FasterSpeeding FasterSpeeding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davfsa davfsa merged commit bc3614e into hikari-py:master Aug 23, 2020
@davfsa davfsa deleted the task/tests branch August 23, 2020 14:20
@ghost ghost added this to the 2.0.0 milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants