Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a target field is cleared validation errors are displayed on all target frequecies fields #626

Closed
amosnjoroge opened this issue May 25, 2020 · 0 comments · Fixed by #655
Closed

When a target field is cleared validation errors are displayed on all target frequecies fields #626

amosnjoroge opened this issue May 25, 2020 · 0 comments · Fixed by #655
Assignees
@Allan690
Labels
defect This doesn't seem right good first issue Good for newcomers
Milestone
Sprint 36

Comments

@amosnjoroge
Copy link
Collaborator

Current behavior
When a target field is cleared validation errors are displayed on all target frequencies' fields

To Reproduce
Steps to reproduce the behavior:

  1. Go to indicator list
  2. Click on more button on one of the indicators and then Target Periods
  3. Clear one of the targets on the frequency's targets
  4. Validation error "The target value field must be numeric and may contain decimal points." on all target fields.

Expected behavior
Clearing a target field should only display a validation error for that field

Screenshots
image
target fields
@amosnjoroge amosnjoroge added the defect This doesn't seem right label May 25, 2020
@andrewtpham andrewtpham added the good first issue Good for newcomers label Jun 15, 2020
@emlorraine emlorraine self-assigned this Jun 16, 2020
@andrewtpham andrewtpham added this to the Sprint 36 milestone Jun 16, 2020
@emlorraine emlorraine assigned emlorraine and unassigned emlorraine Jun 21, 2020
@Allan690 Allan690 self-assigned this Jun 29, 2020
Allan690 pushed a commit that referenced this issue Jun 30, 2020
fix: target field validation errors on clearing
2134dfa 
- fixes issue #626 where clearing a target field lists multiple errors
@Allan690 Allan690 mentioned this issue Jun 30, 2020
Merged
@andrewtpham andrewtpham linked a pull request Jul 2, 2020 that will close this issue
fix: target field validation errors on clearing #655
Merged
andrewtpham added a commit that referenced this issue Jul 11, 2020
@Allan690 @Kimaiyo077 @andrewtpham
fix: target field validation errors on clearing (#655)
4e9ff6a 
- fixes issue #626 where clearing a target field lists multiple errors

Co-authored-by: Allan Mogusu <allanmogusu@Appless-MacBook-Pro.local>
Co-authored-by: Isaac Kimaiyo <40719885+Kimaiyo077@users.noreply.github.com>
Co-authored-by: Andrew <andrew.tc.pham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Allan690 Allan690

Labels
defect This doesn't seem right good first issue Good for newcomers
Projects
None yet
Milestone
Sprint 36
Development

Successfully merging a pull request may close this issue.

fix: target field validation errors on clearing hikaya-io/activity
4 participants
@andrewtpham @amosnjoroge @Allan690 @emlorraine