Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Target column in the Indicator list is not updated when Target Periods are added #638

Closed
amosnjoroge opened this issue Jun 16, 2020 · 0 comments · Fixed by #643
Closed

The Target column in the Indicator list is not updated when Target Periods are added #638

amosnjoroge opened this issue Jun 16, 2020 · 0 comments · Fixed by #643
Assignees
@Allan690
Labels
defect This doesn't seem right good first issue Good for newcomers ready for development These are issues ready to be taken on.

Comments

@amosnjoroge
Copy link
Collaborator

Current behavior
The Target column in the Indicator list is not updated when Target Periods are added. Only when the page is refresh does the target display.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'the indicators list page
  2. Click on the more button and select Target Periods
  3. Enter the Overall target and frequency targets and Save
  4. The Target column of the indicator is empty

Expected behavior
When a target period is entered and save the overall target value should be displayed for that indicator.

Screenshots
Overal Target
@amosnjoroge amosnjoroge added good first issue Good for newcomers defect This doesn't seem right labels Jun 16, 2020
@andrewtpham andrewtpham added the ready for development These are issues ready to be taken on. label Jun 16, 2020
Allan690 pushed a commit that referenced this issue Jun 21, 2020
fix: target column in indicator list not updating
0157a04 
- fixes issue where target column in indicator list is not updating
  until refresh

[fixes #638]
@Allan690 Allan690 mentioned this issue Jun 21, 2020
Merged
@andrewtpham andrewtpham linked a pull request Jun 21, 2020 that will close this issue
fix: target column in indicator list not updating #643
Merged
andrewtpham pushed a commit that referenced this issue Jun 22, 2020
@Allan690
fix: target column in indicator list not updating (#643)
257646f 
- fixes issue where target column in indicator list is not updating
  until refresh

[fixes #638]

Co-authored-by: Allan Mogusu <allanmogusu@Appless-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Allan690 Allan690

Labels
defect This doesn't seem right good first issue Good for newcomers ready for development These are issues ready to be taken on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: target column in indicator list not updating hikaya-io/activity
3 participants
@andrewtpham @amosnjoroge @Allan690