Fix: The "End of Program " column should use the Overall Target value #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allan690
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #647 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 127 127
Lines 8481 8481
=======================================
Hits 4679 4679
Misses 3802 3802 Continue to review full report at Codecov.
|
|
@Allan690 do you mind rebasing this to |
Sure...it's actually rebased to develop..the main branch has not been changed that's why it's still pointing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
Fixes issue #645
What was the approach?
The issue was coming from reports/views in the GenerateReport view, the total_targeted should be derived from the lop_target of an indicator instead of being added from the target periods being reported. Fixed this based on @Kimaiyo077 's comment
Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@Kimaiyo077 @andrewtpham
Issue(s) affected?
#645