Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize resources dev stag #657

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Conversation

Darius-Ndubi
Copy link
Contributor

@Darius-Ndubi Darius-Ndubi commented Jul 16, 2020

What is the Purpose?

Configure staging and dev to share resources

What was the approach?

Destroy staging cluster and configure it to deploy to dev cluster

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@andrewtpham @sannleen

Issue(s) affected?

List of issues addressed by this PR.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #657 into develop will increase coverage by 0.01%.
The diff coverage is 98.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #657      +/-   ##
===========================================
+ Coverage    55.17%   55.18%   +0.01%     
===========================================
  Files          127      130       +3     
  Lines         8481     8478       -3     
===========================================
  Hits          4679     4679              
+ Misses        3802     3799       -3     
Impacted Files Coverage Δ
activity/settings/base.py 100.00% <ø> (ø)
formlibrary/admin.py 100.00% <ø> (ø)
...brary/migrations/0008_delete_trainingattendance.py 100.00% <ø> (ø)
formlibrary/models/construction.py 100.00% <ø> (ø)
formlibrary/models/distribution.py 100.00% <ø> (ø)
formlibrary/models/training.py 100.00% <ø> (ø)
formlibrary/tests/test_training_attendance.py 100.00% <ø> (ø)
formlibrary/urls.py 100.00% <ø> (ø)
reports/views.py 16.58% <0.00%> (+0.08%) ⬆️
formlibrary/migrations/0008_auto_20200521_1610.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9ff6a...9112dd4. Read the comment docs.

@Darius-Ndubi Darius-Ndubi marked this pull request as ready for review July 16, 2020 17:58
@andrewtpham andrewtpham merged commit bcc8086 into develop Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants