Fix deploy template error #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darius-Ndubi
force-pushed
the
optimize-resources-dev-stag
branch
from
7922e65
to
a9709e8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #658 +/- ##
========================================
Coverage 55.18% 55.18%
========================================
Files 130 130
Lines 8478 8478
========================================
Hits 4679 4679
Misses 3799 3799 Continue to review full report at Codecov.
|
andrewtpham
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
Fix deploy template error
What was the approach?
Minimum pods were being read as a string rather than an integer.A variable replacement was not occurring before deployment
Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@andrewtpham
Issue(s) affected?
None