Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add command to copy settings file #780

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

TAnas0
Copy link
Collaborator

@TAnas0 TAnas0 commented Apr 14, 2022

What is the Purpose?

Resolves #779

What was the approach?

There was a missing command to copy the settings file before launching the app

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@ninetteadhikari @andrewtpham

Issue(s) affected?

Resolve #779

andrewtpham
andrewtpham previously approved these changes Apr 14, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #780 (8e8a836) into develop (abdcd53) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #780   +/-   ##
========================================
  Coverage    57.55%   57.55%           
========================================
  Files          140      140           
  Lines         9210     9210           
========================================
  Hits          5301     5301           
  Misses        3909     3909           

Copy link
Member

@andrewtpham andrewtpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @amosnjoroge 🐎

@andrewtpham andrewtpham merged commit 2e7777d into develop Sep 20, 2022
@andrewtpham andrewtpham deleted the docs-readme-copy-settings-file branch September 20, 2022 08:00
andrewtpham pushed a commit that referenced this pull request Sep 22, 2022
* docs: add command to copy settings file

* included a step to copy setting file during docker build

Co-authored-by: Amos Njoroge <sannleen@gmail.com>
andrewtpham added a commit that referenced this pull request Sep 22, 2022
* Build(deps): Bump oauthlib from 3.1.1 to 3.2.1

Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.1.1 to 3.2.1.
- [Release notes](https://github.com/oauthlib/oauthlib/releases)
- [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst)
- [Commits](oauthlib/oauthlib@v3.1.1...v3.2.1)

---
updated-dependencies:
- dependency-name: oauthlib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* docs: add command to copy settings file (#780)

* docs: add command to copy settings file

* included a step to copy setting file during docker build

Co-authored-by: Amos Njoroge <sannleen@gmail.com>

* upgrade dependencies (#786)

* upgrade dependencies

* update requirements.in

* remove google oauth

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anas TIOUR <anastiour@gmail.com>
Co-authored-by: Amos Njoroge <sannleen@gmail.com>
Co-authored-by: Andrew <4407063+andrewtpham@users.noreply.github.com>
Co-authored-by: andrewtpham <andrew.tc.pham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running docker-compose gives 'module not found error'
3 participants