add support for reading mqtt password from file #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikhvar
requested changes
Jan 29, 2023
Hi @hikhvar pushed a new commit with both comments handled. Can you pls take a look? |
hikhvar
approved these changes
Jan 30, 2023
|
@hikhvar not sure if you follow certain release schedule, and merge PRs just before master build. But wanted to remind you that this PR is in approved state, but not yet merged with master, and I can't pull new image in my deployment until you do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading the password from a secret file. Usually if the base image has a shell, we can modify the entry point to a shell and create the environment variable, (e.g.
/bin/sh -c export MQTT2PROM_MQTT_PASSWORD=$$(cat /var/run/secrets/mqtt-credential); /mqtt2prometheus) but with a distroless base image we don't have that option.Fixes #117