Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing/wrong Octopart break list #338

Closed
mdeweerd opened this issue Oct 25, 2018 · 6 comments
Closed

Missing/wrong Octopart break list #338

mdeweerd opened this issue Oct 25, 2018 · 6 comments
Labels
enhancement Improvements on features already existent. need-info Need extra information or incomplete description provide by the user.

Comments

@mdeweerd
Copy link
Contributor

Kicost gets Euro prices from Octoparts - great ;-).

There are a few improvements that could be done related to pricing:
I have some prices expressed in USD that I specified in a kicost.supplier.pricing field . Example: 500:USD2.12;1000:USD1.90 . I noted that a currency module for python was installed during the installation process and I was hoping that the USD prices would be converted to EUR somehow.

The comment "popup" in excel shows the "$" sign before the prices while they are in EUR. It is possibly on purpose, but only the first two price breaks are listed - it would be interesting to have the full list.
Here is a screenshot:
image

Unfortunately Octopart prices are not correct and have fewer prices breaks than the distributer (I attach screenshots of the Octopart prices and the Distributor prices taken at the same moment). So a part looks much more expensive than it actually is.
Kicost is reusing the right values from Octopart though - so no action for the Kicost tool
Screenshots of the pricing according to Octopart and Mouser:
image
image

@hildogjr
Copy link
Owner

hildogjr commented Oct 25, 2018

@mdeweerd, confirm me, there is 2 issues:

  1. The symbol should be correlated with the converted currency and the values are fine (converted correctly);
  2. It is not shown the complete price break list as in the web sites.

About 1, yet, it uses a currency converter, so could exist some minimum difference between the converted value present by KiCost and by Octopart (Octopart also convert the prices but not provide the converted values in the API).
I am working to get a up to date currency rate.

@hildogjr hildogjr added the enhancement Improvements on features already existent. label Oct 25, 2018
@hildogjr hildogjr self-assigned this Oct 25, 2018
@hildogjr hildogjr reopened this Oct 25, 2018
@hildogjr hildogjr changed the title EUR pricing in Kicost - some prices still listed in USD Missing/wrong Octopart break list Oct 25, 2018
@hildogjr
Copy link
Owner

hildogjr commented Oct 25, 2018

The symbols issue was fixed, try it.
Missing fix the break price issue.

@mdeweerd
Copy link
Contributor Author

  1. The currency symbol in the comment popup should be the same as the currency displayed.
    This is/was not the case (you say you fixed it);
    Possibly, if the currency was converted it would be a nice to have to show the value in the original currency and in the converted currency.
    Example: "10: 2.00 EUR (2.51USD)"
  2. The price break list in the popup should be complete. Currently only 2 lines are shown.
    The prices shown were already the same as the ones that are used in the spreadsheet, so that is ok.
  3. When prices are entered in the specific Kicost field in USD, but the spreadsheet is in EUR, then the prices should be converted from EUR to USD. This is not currently the case.
    I specified "500:USD2.12;1000:USD1.90" in the "kicost.supplier.pricing" field of a component and these prices were interpreted as EUR. Ideally in the comment I would have something like "500: 1.87 EUR (2.12USD)" and of course also the correct pricing for the BOM line and total.

@hildogjr hildogjr added the need-info Need extra information or incomplete description provide by the user. label Oct 30, 2018
@hildogjr
Copy link
Owner

@mdeweerd, I checked I could get all the price breaks. Could you re-check, and re-open if still? The others improvements are in the list.
screenshot from 2018-10-30 14-26-22

I am first modifying KiCost to respect the API terms of use. #331

@mdeweerd
Copy link
Contributor Author

mdeweerd commented Oct 30, 2018

Hi
I do not know what means exactly "The others improvements are in the list.", here are my observations:

The currency symbol is now € when EUR is specified.
However, there are still these two behaviors:

  • kicost.supplier.pricing="500:USD2.12;1000:USD1.90" has two price breaks, the sheet shows two prices, but the interpretation is not ok. Minimum order is 500, 1000 units price break is not shown - also not that the title still shows "$" (could be removed from header):
    image
  • "500:USD2.12;1000:USD1.90" is expressed in USD, but the prices shown in EUR are the same. I thought there would be a currency conversion.

I had to disable octopart to make this test as my API has been disabled.

hildogjr added a commit that referenced this issue Oct 30, 2018
@hildogjr
Copy link
Owner

hildogjr commented Oct 30, 2018

More than one issue reported in one topic usually create some misunderstood. I fix the symbols in the title.
I will let you up-to-date.
If possible, attache here your BOM.

@hildogjr hildogjr reopened this Oct 30, 2018
@hildogjr hildogjr removed their assignment Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements on features already existent. need-info Need extra information or incomplete description provide by the user.
Projects
None yet
Development

No branches or pull requests

2 participants