ui: fix progress bar on python 3.10+ #532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently python 3.10 no longer silently truncates floats to ints, (see python/cpython#82180)
Current code passes a float to the wxGauge progress bar, which then prints (not) tracebacks like:
TypeError: Gauge.SetValue(): argument 1 has unexpected type 'float' Traceback (most recent call last):
File "/usr/lib64/python3.10/site-packages/wx/core.py", line 3285, in
lambda event: event.callable(*event.args, **event.kw) )
At least someone is catching and ignoring the exception, so the app works, just the progress bar is broken.
It just needs to be explicitly forced to an int to make it work again
Signed-off-by: Karl Palsson karlp@etactica.com