Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 20131022 #17

Closed
wants to merge 2 commits into from
Closed

Patch 20131022 #17

wants to merge 2 commits into from

Conversation

msigley
Copy link

@msigley msigley commented Oct 22, 2013

Added a default callback function for easier use based on the Groupon Getaways example. It requires no existing html and adds contextual html for css styling. This should make the plugin much easier to use.

I also fixed a bug that occurs milliseconds are passed in for toDate. It wasn't being properly cast as an integer before being passed into the Date object constructor.

@hilios
Copy link
Owner

hilios commented Oct 25, 2013

Hey @msigley thank you for your pull request. I will generate a version and merge ASAP!

@msigley
Copy link
Author

msigley commented Oct 25, 2013

Thanks @hilios. Hope my work helps others use your wonderful jQuery plugin :). Let me know if you have any questions.

@hilios
Copy link
Owner

hilios commented Oct 25, 2013

@msigley could you send this pull request to branch v1.0.1?

Also, I am releasing the version 2.0.0, and already included your fix and a test case for it. Thanks again!

@hilios hilios closed this Oct 25, 2013
@msigley
Copy link
Author

msigley commented Oct 25, 2013

Why not just merge v1.0.1 or v2.0.0 with the master? The master is supposed to be the latest in progress work. I'll be more than happy to adapt my changes for v2.0.0 after you update the master

@msigley
Copy link
Author

msigley commented Oct 25, 2013

PS don't forget to give props to me in the commit for the bug fix ;)

@hilios
Copy link
Owner

hilios commented Oct 28, 2013

@msigley in the v2.0.0 I included you and few others that contributed on README and on comments in the source code. Hope that you are pleased with this.

Thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants