-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requireJS for version 2.0.0 #18
Conversation
@@ -0,0 +1,9 @@ | |||
module('requireJS'); | |||
|
|||
asyncTest('test requireJS support', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we create a single test for requireJS instead of running the whole suite, which would be pretty useless once we agree the support is working
After reviewing this I realized it may not be necessary to create a separate file or hide the jquery global. |
By the way, can't you use |
Everything in this pull request should be used under wtfpl public license |
I agree with you about using the By the way, this is much a cleaner way to test the requirejs support, great job! I will merge this right away. Thanks, |
I don't understand. Which element? |
Never mind! |
Few notes:
Due to some error with
npm install -d
while installing thequnit
grunt plugin I had to downgrade it to the version1.0.0
to make it work.I will comment each line explaining the changed