Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc and fixes for policy kwargs #165

Merged
merged 7 commits into from
Jan 17, 2019
Merged

Add doc and fixes for policy kwargs #165

merged 7 commits into from
Jan 17, 2019

Conversation

araffin
Copy link
Collaborator

@araffin araffin commented Jan 15, 2019 •
edited
Loading

Cf #162

  • Add an example in the doc
  • Update the tests to test more models
  • Add a check to avoid wrong keywords
  • Fix TRPO not passing policy_kwargs
  • Add customization of activation function for DDPG, SAC and DQN

@araffin araffin requested review from ernestum and hill-a January 15, 2019 17:06
@araffin
Copy link
Collaborator Author

araffin commented Jan 15, 2019

@hill-a @erniejunior
Apparently my new check found some errors that were before ^^`
I'll update that soon but you can already review this PR.

Repository owner deleted a comment from araffin Jan 16, 2019
ernestum
ernestum requested changes Jan 16, 2019
View reviewed changes
Copy link
Collaborator

@ernestum ernestum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all the documentation and minor polishing touches. This is really valuable and I did not have time for those.

stable_baselines/common/policies.py Show resolved Hide resolved
tests/test_custom_policy.py Outdated Show resolved Hide resolved
docs/guide/custom_policy.rst Show resolved Hide resolved
ernestum
ernestum previously approved these changes Jan 17, 2019
View reviewed changes
@araffin
Copy link
Collaborator Author

araffin commented Jan 17, 2019

@erniejunior if you approve the PR, you can merge it with master when the CI pass ;)
Btw, please use "squash and merge".

@araffin araffin merged commit 396e0fa into master Jan 17, 2019
@araffin araffin deleted the policy-kwargs-doc branch January 17, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestum ernestum ernestum left review comments

@hill-a hill-a hill-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@araffin @ernestum @hill-a