Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I upgrade from 3.8.0 to anything else, the page breaks. #11

Closed
the-real-graybags opened this issue Aug 21, 2024 · 6 comments
Closed

Comments

@the-real-graybags
Copy link

Hi,

I've not visited here for a while, but I thought I'd see if there has been any developments, and there really has!

My glossary is using 3.8.0, and if I change it too anything more recent than that, I just get a page saying "Glossary Page Template
This page includes a web interface..."

Clearly I've done something wrong, but what is it?! Thanks.

Gray

@hilverd
Copy link
Owner

hilverd commented Sep 10, 2024

I haven't been able to reproduce this yet, unfortunately -- are you hosting the static assets yourself or pointing to glstatic.net? Can you maybe share the glossary file and/or the steps you were following to upgrade in more detail please?

@the-real-graybags
Copy link
Author

the-real-graybags commented Sep 11, 2024

I'm pointing to glstatic.net. Works with 3.8.0 but not with 5.

It's obviously something I've done wrong my end :( , so I've editted and attached my file.

glossary2.zip

hilverd added a commit that referenced this issue Sep 15, 2024
@hilverd
Copy link
Owner

hilverd commented Sep 15, 2024

Thanks for reporting this and helping me reproduce this. You weren't doing anything wrong -- I had changed the behaviour without documenting this properly 😬.

From version 4.0.0 onwards, opening the glossary.html file directly in a browser (as a file:// URL) only shows the help message, not the actual glossary. So opening it as a file in the browser now just meant as a starting point. To see the glossary contents, you will need to either use the node command in the help message that runs the built-in editor, or "host" the file using e.g.

python3 -m http.server 8000

For what it's worth, I was forced to make this change so that I could start using query parameters (to keep track of the tag currently being filtered by, and the current sort order), and I couldn't see any good alternatives. It's unfortunate that this adds more friction.

(I've belatedly documented this change in the CHANGELOG and the release notes for version 4.0.0.)

@the-real-graybags
Copy link
Author

the-real-graybags commented Sep 15, 2024 via email

@hilverd
Copy link
Owner

hilverd commented Nov 12, 2024

Sorry for the delay -- yes opening a glossary file via a file:// URL no longer works properly after 3.8.0. But I think I have found a way to fix that. I will also add an option under "Settings" to allow changing the default theme.

I will post an update here once I have managed to release those changes.

hilverd added a commit that referenced this issue Nov 16, 2024
This is used if the user has not explicitly picked a theme, and has also
not indicated a preference for dark mode in their browser settings.
@hilverd
Copy link
Owner

hilverd commented Nov 18, 2024

This should now be fixed in v5.1.0 which also adds the ability to change the default theme.

If you want to try it then hopefully upgrading shouldn't be too painful, although there were breaking changes in v4.0.0 and v5.0.1.

I'll close this issue now but can reopen it if something isn't OK.

@hilverd hilverd closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants